Update dns resolution for socks proxies #19683
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfoster-r7
commented
Nov 28, 2024
lib/msf/core/opt_proxies.rb
Outdated
| value | ||
| end | ||
|
|
||
| def valid?(value=self.value, check_empty: true, datastore: nil) |
There was a problem hiding this comment.
Will extract out to a separate PR; I noticed it's possible to assign invalid values to the proxies datastore option. This should tighten things up, but the UX still isn't great IMO
adfoster-r7
force-pushed
the
update-dns-resolution-for-socks-proxies
branch
2 times, most recently
from
e3dc810
to
bb3d05c
Compare
adfoster-r7
force-pushed
the
update-dns-resolution-for-socks-proxies
branch
from
bb3d05c
to
2c78d21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves #19641
Update dns resolution for socks proxies. Now local DNS resolution will be skipped on the host machine and deferred to any configured socks proxies, i.e. with
setg proxies socks5:127.0.0.1:1080Verification
Ensure CI passes