Merge pull request #246 from rapid7/issue-237

Support setting Id on policy documents

lib/convection/model/mixin/policy.rb

@@ -41,10 +41,12 @@ def deny(sid = nil, &block)
         end
 
         def document
-          {
+          doc = {
             'Version' => version,
             'Statement' => statement.map(&:render)
           }
+          doc['Id'] = id if id
+          doc
         end
 
         def render(parent = {})

spec/convection/model/template/resource/policy_document_spec.rb

@@ -0,0 +1,17 @@
+require 'spec_helper'
+
+module Convection::Model::Mixin
+  describe Policy do
+    let(:template) { double(:template) }
+    subject { described_class.new(name: 'test-policy', template: template) }
+
+    it 'does not set Id on #document if absent' do
+      expect(subject.document['Id']).to be_nil
+    end
+
+    it 'sets Id on #document if provided' do
+      subject.id('MyDocumentId')
+      expect(subject.document['Id']).to eq('MyDocumentId')
+    end
+  end
+end