🌱 Use calico as alternative to kindnet in e2e tests, and start testing helm chart proxy #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danil Grigorev <[email protected]>
Signed-off-by: Danil Grigorev <[email protected]>
Signed-off-by: Danil Grigorev <[email protected]>
Danil-Grigorev
force-pushed
the
use-calico
branch
2 times, most recently
from
17ca395
to
35d7754
Compare
Signed-off-by: Danil Grigorev <[email protected]>
alexander-demicev
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
approved, I like that we will include CAPI addon providers in tests, @Danil-Grigorev please fix the conflict
|
@Danil-Grigorev looks like this needs a rebase. Just out of curiosity, do you still need this change to run the test suite locally after changing the CIDR block to potentially avoid collisions? |
|
I think this can be closed now. Remaining functionality of this PR is superseded by #654 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR provides alternative to kindnet network setup with calico. In my environment it is needed to make the local tests pass.
Additionally this introduces tests for helm addon provider as means for installing Calico CNI in the child cluster.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: