Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: reword providers section #139

Conversation

salasberryfin
Copy link
Contributor

@salasberryfin salasberryfin commented Jul 11, 2024

Description

After discussions with the team and product, we agreed that we should substitute the term "supported" from the documentation and reflect that the providers are verified/validated instead.

Fixes #134

@salasberryfin salasberryfin added the area/documentation Improvements or additions to documentation label Jul 11, 2024
@salasberryfin salasberryfin requested a review from a team July 11, 2024 13:33
@salasberryfin salasberryfin force-pushed the reword-supported-providers-section branch 2 times, most recently from f8c6fc8 to 8f8211a Compare July 15, 2024 08:54
furkatgofurov7
furkatgofurov7 previously approved these changes Jul 15, 2024
Copy link
Contributor

@Danil-Grigorev Danil-Grigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this also be called certified providers? We can expand on the certification process later.

@alexander-demicev
Copy link
Member

@Danil-Grigorev makes sense to me, I already opened an issue about this #136

@salasberryfin
Copy link
Contributor Author

No preference on what term to use from my side @Danil-Grigorev. Maybe we need to confirm if certified is a valid alternative for product?

@salasberryfin
Copy link
Contributor Author

Changed to the proposed certified so that we can also work on a certification process and document how a provider becomes certified.

Danil-Grigorev
Danil-Grigorev previously approved these changes Jul 24, 2024
furkatgofurov7
furkatgofurov7 previously approved these changes Jul 29, 2024
Danil-Grigorev
Danil-Grigorev previously approved these changes Jul 29, 2024
mjura
mjura previously approved these changes Jul 29, 2024
yiannistri
yiannistri previously approved these changes Jul 29, 2024
docs/reference-guides/providers/howto.md Outdated Show resolved Hide resolved
@salasberryfin salasberryfin force-pushed the reword-supported-providers-section branch from 86ad7d0 to e645ddc Compare July 29, 2024 09:05
Copy link
Contributor

@kkaempf kkaempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexander-demicev alexander-demicev merged commit 9af39ac into rancher:main Jul 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Development

Successfully merging this pull request may close these issues.

Reword "supported providers" section
7 participants