Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(kustomize): Deploy latest system-upgrade-controller" #304

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

onno204
Copy link
Contributor

@onno204 onno204 commented Mar 27, 2024

This reverts commit 4e31e5d6a0926df9f370a06c9ea3250ee1e088b1.

This "fixes" issue #302 by reverting the commit that caused the issue.
Currently some installations break because of the missing latest tag on the docker hub as explained by @brandond here

I suggest reverting this PR once a 'latest' tag has been added to the docker hub but for now keep installations working by using a version tag instead of a latest tag.

@mysticaltech
Copy link

Super important folks, please fix ASAP, tons of users affected because of this.

Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: lets move to use the most recent release.

manifests/system-upgrade-controller.yaml Outdated Show resolved Hide resolved
kustomization.yaml Outdated Show resolved Hide resolved
@brandond brandond merged commit f7f79ff into rancher:master Sep 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants