[v2.10] Update LoadUpgradeKubernetesConfig for upgrade refactor #231
+208
−65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Refactor upgrading package to follow current best practices
PR Description
As part of the QA task, we are refactoring the upgrading package to follow the best practices that packages such as
provisioning
andsnapshot
follow. When refactoring, it was agreed upon to havekubernetes_test.go
perform the pre and post upgrade checks instead ofworkload_test.go
. That way, one test runs all of the operations.How it currently is, you have to run 3 individual tests that all pertain to one Kubernetes upgrade. This is being addressed in the r/r PR. For shepherd, we need to update the
LoadUpgradeKubernetesConfig
to ensure that the parameters found inLoadUpgradeWorkloadsConfig
are being referenced.This way, the
kubernetes_test.go
does not need to have to call two separate configs, which is making the refactor overly complicated.