[v2.10] Update LoadUpgradeKubernetesConfig for upgrade refactor #231
+208
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Diamond
approved these changes
Jul 12, 2024
markusewalker
force-pushed
the
markusv29/task-1395
branch
2 times, most recently
from
81d615a
to
0d5a001
Compare
Josh-Diamond
approved these changes
Jul 18, 2024
slickwarren
reviewed
Jul 19, 2024
slickwarren
approved these changes
Jul 19, 2024
markusewalker
force-pushed
the
markusv29/task-1395
branch
2 times, most recently
from
bf71c29
to
9f23faa
Compare
markusewalker
force-pushed
the
markusv29/task-1395
branch
from
9f23faa
to
15b9962
Compare
markusewalker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Refactor upgrading package to follow current best practices
PR Description
As part of the QA task, we are refactoring the upgrading package to follow the best practices that packages such as
provisioningandsnapshotfollow. When refactoring, it was agreed upon to havekubernetes_test.goperform the pre and post upgrade checks instead ofworkload_test.go. That way, one test runs all of the operations.How it currently is, you have to run 3 individual tests that all pertain to one Kubernetes upgrade. This is being addressed in the r/r PR. For shepherd, we need to update the
LoadUpgradeKubernetesConfigto ensure that the parameters found inLoadUpgradeWorkloadsConfigare being referenced.This way, the
kubernetes_test.godoes not need to have to call two separate configs, which is making the refactor overly complicated.