[v2.7] Add docker install support for RKE1 custom cluster #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabhmsra
force-pushed
the
custom_docker_install_2.7
branch
from
6dd70f2
to
1674da1
Compare
rishabhmsra
force-pushed
the
custom_docker_install_2.7
branch
from
1674da1
to
da8ab5f
Compare
slickwarren
previously approved these changes
May 23, 2024
Comment on lines
229
to
230
| type RKE1CustomClusterDockerInstall struct { | ||
| InstallDockerURL string `json:"installDockerURL" yaml:"installDockerURL"` |
There was a problem hiding this comment.
@slickwarren, I've moved it above config, can i get a quick review on this
rishabhmsra
force-pushed
the
custom_docker_install_2.7
branch
from
da8ab5f
to
70cf58d
Compare
rishabhmsra
force-pushed
the
custom_docker_install_2.7
branch
from
70cf58d
to
9289c80
Compare
This was referenced Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we can pass docker version in
cattle-configwhich can be used for installing docker on RKE1 custom cluster nodes.In order to pass docker version, provide below field in the config:
This change is for the AMIs that doesn't have docker pre-installed and are used in docker and OS checks.