Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Fixes for agentEnvVars, updates for proxy tests #163

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

MSpencer87
Copy link
Contributor

Fixes for custom cluster reg strings with env vars

Added helper for setting corral bastion addresses

@MSpencer87 MSpencer87 added the automation-fix To indicate this is related to fixing code related to automation label Apr 29, 2024
@slickwarren
Copy link
Contributor

can you link the rancher/rancher PR here for reference to the updated structs?

Copy link
Contributor

@slickwarren slickwarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly looks solid, just some comments on possibly redundant initializations

extensions/clusters/clusters.go Outdated Show resolved Hide resolved
extensions/clusters/clusters.go Outdated Show resolved Hide resolved
markusewalker
markusewalker previously approved these changes Jul 9, 2024
Copy link
Contributor

@markusewalker markusewalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@markusewalker markusewalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you port these changes over to the backports and 2.10 forwardport so we can merge?

@MSpencer87 MSpencer87 changed the title [v2.9] Fixes for agentEnvVars, updates for proxy tests [main] Fixes for agentEnvVars, updates for proxy tests Sep 10, 2024
Copy link

@igomez06 igomez06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MSpencer87 MSpencer87 merged commit 24fc52a into rancher:main Sep 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation-fix To indicate this is related to fixing code related to automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants