-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add SBOM CRD database storage #13
Merged
fabriziosestito
merged 9 commits into
rancher-sandbox:main
from
fabriziosestito:feat/add-sbom-database-storage
Oct 31, 2024
Merged
feat: add SBOM CRD database storage #13
fabriziosestito
merged 9 commits into
rancher-sandbox:main
from
fabriziosestito:feat/add-sbom-database-storage
Oct 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziosestito
force-pushed
the
feat/add-sbom-database-storage
branch
from
October 29, 2024 16:43
0f3e630
to
30cd326
Compare
Signed-off-by: Fabrizio Sestito <[email protected]>
fabriziosestito
force-pushed
the
feat/add-sbom-database-storage
branch
from
October 30, 2024 14:54
7a3a752
to
e0fd7b2
Compare
flavio
reviewed
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outstanding work! I left some comments
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
fabriziosestito
force-pushed
the
feat/add-sbom-database-storage
branch
from
October 31, 2024 13:04
e0fd7b2
to
25493dc
Compare
…nteedUpdate) Signed-off-by: Fabrizio Sestito <[email protected]>
fabriziosestito
force-pushed
the
feat/add-sbom-database-storage
branch
from
October 31, 2024 13:06
25493dc
to
ab02256
Compare
flavio
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ship it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the SBOM CRD to the database storage.
It implements the apiserver storage interface so that resources can be stored in an external database.
As for now, only sqlite is supported, but it could be extended to other databases by changing the driver.
We are using modernc.org/sqlite which does not require CGO enabled.
The watch is implemented by using watch.Broadcaster.
The store can be generalized by using generics to support the other CRD provided by the storage component (Image, VulnerabilityReport).