Fix: Status bar switches to icon view too early #7576
Conversation
VikalpRusia
changed the title
VikalpRusia
force-pushed
the
status-bar-fix
branch
2 times, most recently
from
742e4db to
ba1ef59
Compare
VikalpRusia
changed the title
|
Thank you! I haven't looked at the PR, but I've tested it for a bit and have 2 comments:
I assume this happens because we reserve a certain amount of space for the status messages, even when they are actually much shorter? This is not really important though; when the progress bar is gone the status line springs back to full width.
Note how the version string in my example is much longer than in yours. I don't know if you dynamically determine the width of the status bar, or just reserve a certain amount of space for it. |
|
BTW, if you take a screenshot on macOS with ⌘⇧4, you can press the space bar while hovering over a window to just capture that window and don't have to select the rectangle manually (and include parts of the background). |
There was a problem hiding this comment.
FWIW, I think we should not switch based on if the status bar is visible, because that means a lot of movement when the status bar pops up. But with a lack of proper UI people right now I defer to Jan for those decisions.
This does look like way too much whitespace though; note that the version isn't even visible here…
| @@ -74,7 +74,7 @@ export default Vue.extend({ | |||
|
|
|||
| methods: { | |||
| submit() { | |||
| this.$emit('click', { action: this.action, image: this.image }); | |||
| this.$emit('click', { action: this.action, image: this.image.trim() }); | |||
There was a problem hiding this comment.
Was this meant to go into a different PR?
There was a problem hiding this comment.
yup, its better if we create another PR was a backlog item.
| @@ -61,20 +65,23 @@ export default Vue.extend({ | |||
| <img | |||
| v-if="isSvgIcon" | |||
| class="item-icon icon-svg" | |||
| :class="{'make-icon-inline': isProgressBarVisible}" | |||
There was a problem hiding this comment.
The various make-* classes are awkward:
- The
make-prefix is repetative, and doesn't really say much - They're all doing the same thing, but with lots of different names
I'd suggest just collapsed instead. Or, even better, move it to a parent element (the actual status bar?) and use CSS rules to select them.
|
@VikalpRusia Ping! Do you still intend to work on this? For the mean time I'm going to turn it into draft mode, so it doesn't show up every day during our standup when we go through open PRs. |
|
@jandubois I will try to complete it this week. Thanks for making it draft |
Signed-off-by: Vikalp Rusia <[email protected]>
Signed-off-by: Vikalp Rusia <[email protected]>
Signed-off-by: Vikalp Rusia <[email protected]>
Signed-off-by: Vikalp Rusia <[email protected]>
VikalpRusia
force-pushed
the
status-bar-fix
branch
from
1bfab2b to
6887467
Compare
Bug
Status bar icon collapses even when bar has space
Why?
Hard coded for giving space to the progress bar
More details
#6514
Changes
Screenshots
closes #6514