Postinstall: Try harder to retry #7528
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Promise.any` will only raise an exception when all of the promises have rejected (or any promise has resolved); use `Promise.race` instead, where the first rejecting promise raises. Signed-off-by: Mark Yen <[email protected]>
mook-as
force-pushed
the
postinstall/download-retry
branch
from
c385ffa to
16d993a
Compare
This reimplements fetchWithRetry to manually watch the progress of the download, and if there has been no progress in five seconds, abort the download and retry. This will hopefully resolve issues in CI where the whole download times out after ten minutes because the downloads get stuck. Signed-off-by: Mark Yen <[email protected]>
mook-as
force-pushed
the
postinstall/download-retry
branch
from
16d993a to
2b3e9ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-implements the download retry logic for post-install downloads (lima-alpine images, etc.) so that we can attempt to retry harder when things go wrong (in particular, if we end up going 5 seconds without getting any data). Hopefully this will reduce the chance of us hitting the ten minute timeout.