Spike: Deploy Rancher Manager #7352
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will replace the bundled version of dashboard and steve with the normal version to explore how that will work. Signed-off-by: Mark Yen <[email protected]>
This installs Rancher Manager (but doesn't go through the setup). This is not yet very useful. Signed-off-by: Mark Yen <[email protected]>
We are (at least for now) disabling dashboard extensions to reduce the amount of stuff we have to worry about. We may end up re-enabling them before this is merged (after cleanup).
Since ingress doesn't currently work on Windows, use envoy to do SSL termination and do Kubernetes-level service port forwarding instead. This also means it will work without traefik.
|
Replaced ingress with an envoy pod doing SSL termination and port forwarding via our existing port forwarding logic; this now works on Windows, and doesn't require traefik (but might get cancelled by the user; we still need to fix that). GitGuardian is already complaining about the hard-coded cert I placed in the envoy config (which we never verify anyway). It might be worth it to replace envoy with a golang-based proxy that generates certs on the fly (and, again, never gets verified). |
We need to override the origin when talking to upstream, as the header normally contains the downstream port and gets rejected. Also add a timeout to dashboard setup so we can retry instead of hanging forever if it doesn't work.
They generate kubeconfig files that have no port, which does not work as we require port forwarding to reach the server. To avoid confusing users, hide the buttons.
- When we create an error, we need to throw in, not drop it on the floor. - If the host port is not specified, and an existing server is found, return that server's port instead of 0.
|
The Apps section doesn't work. It does if we stop disabling the |
|
Some observations from my brief testing on Windows so far:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR to explore using Rancher Manager in place of our partial dashboard. Reviewing the code isn't going to be that helpful yet (needs a lot of cleanup before it is ready for review), but it will be useful to try out a CI build.
It just installs the helm chart instead of manually running Steve + dashboard bits.
Notes:
https://localhost/with the dashboard. We will need to figure out a way to make this work without doing that.This is for #7322.