Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix feature conflicts #222

Closed
wants to merge 8 commits into from
Closed

Fix feature conflicts #222

wants to merge 8 commits into from

Conversation

marioortizmanero
Copy link
Collaborator

Closes #221

@marioortizmanero marioortizmanero marked this pull request as draft July 7, 2021 23:26
@marioortizmanero marioortizmanero changed the base branch from master to rename-http-error July 7, 2021 23:26
@marioortizmanero
Copy link
Collaborator Author

marioortizmanero commented Jul 7, 2021 •
edited
Loading

The concept of being generic over the http client can definitely work. The wall I've just hit though is that maybe_async itself is a toggle; you can't have both async and blocking at the same time (check this convenient issue out: fMeow/maybe-async-rs#6). So I have to find a way to make that possible. Also, the paginators conflict.

@marioortizmanero marioortizmanero mentioned this pull request Jul 8, 2021
Open
Base automatically changed from rename-http-error to auth-rewrite-part3 July 8, 2021 02:14
Base automatically changed from auth-rewrite-part3 to auth-rewrite-part2 July 8, 2021 02:19
Base automatically changed from auth-rewrite-part2 to auth-rewrite-part1 July 8, 2021 03:34
Base automatically changed from auth-rewrite-part1 to separate-crates July 8, 2021 03:40
Base automatically changed from separate-crates to master July 8, 2021 09:48
@marioortizmanero marioortizmanero changed the title Fix conflicts Fix feature conflicts Aug 20, 2021
@marioortizmanero marioortizmanero mentioned this pull request Sep 19, 2021
Closed
3 tasks
@marioortizmanero
Copy link
Collaborator Author

Superseded by #253 with a different idea

@marioortizmanero marioortizmanero deleted the fix-conflicts branch September 19, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoiding conflicting features; allow multiple HTTP clients at once
1 participant
@marioortizmanero