-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ops #95
base: v1
Are you sure you want to change the base?
Add Ops #95
Conversation
object WeePickle extends LowPriorityImplicits { | ||
object WeePickle | ||
extends LowPriorityImplicits | ||
with FromInputOpsImplicits { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future, I expect to add FromOpsImplicits
/ToOpsImplicits
/VisitorOpsImplicits
for .tolerant
, etc. Grouping the extensions into a "high level extension ops" traits seems like it should help discoverability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would be a good thing to add to the code, it explains your reasoning which is often hard to "reverse engineer" from the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also BufferedValueOps
?
object BufferedValueOps { |
6e90bd9
to
18cf0a7
Compare
+1 to put it in with the rest of the stuff. Having to manage multiple JAR versions is always a little error prone. |
object WeePickle extends LowPriorityImplicits { | ||
object WeePickle | ||
extends LowPriorityImplicits | ||
with FromInputOpsImplicits { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would be a good thing to add to the code, it explains your reasoning which is often hard to "reverse engineer" from the code.
object WeePickle extends LowPriorityImplicits { | ||
object WeePickle | ||
extends LowPriorityImplicits | ||
with FromInputOpsImplicits { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also BufferedValueOps
?
object BufferedValueOps { |
This is a first step toward open sourcing some of our higher-level weePickle code, starting with
ConcatFromInputs
. The big decision is where it should live. We could carve out another jar, but I think it makes the sense to add most of thevisitation
stuff directly toweepickle-core
.