Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor tweaks from migrating SciGateway to Vite #393 #420

Merged
merged 6 commits into from
Mar 25, 2024

Conversation

joelvdavies
Copy link
Collaborator

@joelvdavies joelvdavies commented Mar 19, 2024

Description

Applies the tweaks described in #393, found while migrating SciGateway to use Vite in ral-facilities/scigateway#1380.

Notes

  • Uses browserslist-to-esbuild to add support for browserslist (View the currently targeted builds using npx browserslist-to-esbuild)

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage
  • Test the docker build still works correctly (try a few different browsers)

Agile board tracking

Closes #393

@joelvdavies joelvdavies self-assigned this Mar 19, 2024
@joelvdavies joelvdavies added enhancement Improved or refactored feature maintenance (non-MVP) labels Mar 19, 2024
@joelvdavies joelvdavies force-pushed the vite-migration-tweaks-#393 branch from 2187b48 to 1dfef2d Compare March 19, 2024 14:32
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.64%. Comparing base (13ccfcd) to head (a3d8003).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #420      +/-   ##
===========================================
- Coverage    93.66%   93.64%   -0.02%     
===========================================
  Files           60       61       +1     
  Lines        15998    16156     +158     
  Branches      2075     2099      +24     
===========================================
+ Hits         14985    15130     +145     
- Misses        1007     1020      +13     
  Partials         6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelvdavies joelvdavies force-pushed the vite-migration-tweaks-#393 branch from 1cd5cbd to 977c20f Compare March 21, 2024 10:31
@joelvdavies joelvdavies marked this pull request as ready for review March 21, 2024 13:43
@joelvdavies joelvdavies merged commit 15c6b97 into develop Mar 25, 2024
4 checks passed
@joelvdavies joelvdavies deleted the vite-migration-tweaks-#393 branch March 25, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improved or refactored feature maintenance (non-MVP)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor tweaks after Vite migration
4 participants