Enhance catalogue item properties table view filter #1128 #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuadkitenge
changed the base branch from
develop
to
enhance-catalogue-category-card-filters-#1124
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1157 +/- ##
========================================
Coverage 99.15% 99.16%
========================================
Files 89 89
Lines 17785 17865 +80
Branches 2966 2973 +7
========================================
+ Hits 17635 17715 +80
Misses 146 146
Partials 4 4 ☔ View full report in Codecov by Sentry. |
joshuadkitenge
force-pushed
the
enhance-catalogue-item-properties-table-view-filter-#1128
branch
from
4ab0040 to
67a2185
Compare
Base automatically changed from
enhance-catalogue-category-card-filters-#1124
to
develop
December 17, 2024 09:22
asuresh-code
requested changes
Dec 19, 2024
| @@ -117,6 +213,7 @@ export function CatalogueItemsPropertiesTable(props: PropertiesTableProps) { | |||
| data: properties, | |||
| // Features | |||
| enableTopToolbar: true, | |||
| enableColumnFilterModes: true, | |||
There was a problem hiding this comment.
Suggested change
| enableColumnFilterModes: true, | |
| enableColumnFilterModes: true, | |
| filterFns: customFilterFunctions, |
|
The exclude functions currently don't work on list column values. Develop needs to be merged into this branch, since this PR had some changes to the utility functions that fixes it. |
asuresh-code
approved these changes
Dec 19, 2024
joshuadkitenge
deleted the
enhance-catalogue-item-properties-table-view-filter-#1128
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
closes #1128