Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary open config to match SciGateway #1144

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

joelvdavies
Copy link
Collaborator

Description

From comment on ral-facilities/scigateway#1380.

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.19%. Comparing base (b50268b) to head (0a2f462).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1144   +/-   ##
========================================
  Coverage    99.19%   99.19%           
========================================
  Files           82       82           
  Lines        17085    17085           
  Branches      2844     2844           
========================================
  Hits         16947    16947           
  Misses         134      134           
  Partials         4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelvdavies joelvdavies merged commit 1935ec3 into develop Dec 4, 2024
6 checks passed
@joelvdavies joelvdavies deleted the remove-unnecessary-vite-config branch December 4, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants