-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty Where Filter Input on Count Endpoints #326
base: main
Are you sure you want to change the base?
Empty Where Filter Input on Count Endpoints #326
Conversation
The failing test jobs will be fixed by #325 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just need to reword the error message as per my comment and merge master in once #325 is merged so the CI passes.
Codecov Report
@@ Coverage Diff @@
## master #326 +/- ##
=======================================
Coverage 92.62% 92.62%
=======================================
Files 43 43
Lines 3199 3242 +43
Branches 318 325 +7
=======================================
+ Hits 2963 3003 +40
- Misses 198 200 +2
- Partials 38 39 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, we should probably wait to merge this PR so we can keep one in reserve for the DOI minting discussed on Slack.
…oints-with-non-existent-dataset-pid-#327 Return 404 on /files and /files/count endpoints with non-existent dataset pid
This was waiting for a DOI to be minted for the search API. I believe this is unlikely to happen now, so the merge conflicts should be resolved and the PR should be merged. |
This PR will close #309
Description
The changes in this PR make the count endpoints work when they receive an empty where filter input (
where={}
). Also added some extra code so thatFilterError
is raised when the where filter input is not an object.Testing Instructions
icatdb Generator Script Consistency Test
CI job fails, is this because of a deliberate change made to the script to change generated data (which isn't actually a problem) or is here an underlying issue with the changes made?fix:
,feat:
orBREAKING CHANGE:
so a release is automatically made via GitHub Actions upon merge?