Add ability to have notes in print-pdf #142
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch as an overlay canvas to the generated PDF print version to render the notes added to the slides. To keep the current default behavior, this feature must be enabled by setting the new configuration option "printNotes" to `true`. Unfortunatly the relative positioning between the drawings and the slide content is not perfect since th rendering of the slide content slightly differs in the pdf-print mode. This patch adresses issue rajgoel#97
|
Is there anything keeping this from being merged? Thinking about forking for my own lectures. |
|
Yes, the limitation regarding the relative positioning:
I didn't check myself, but this can be a real problem (in particual for different screen sizes e.g. phones). |
|
If there is a quality indication about the worst case offset that can occur I'd be willing to inspect this in more detail. |
|
I'm not sure what that offset would be in print, but I do find huge offsets between different screen sizes for the default margins and scaling factors.
I need to set margins to below 5% and Max scale to >5 to make the drawings match up between recording and replay.
So the offset issue is not necessarily related to the print output, but a deeper issue?
…________________________________
From: Asvin Goel ***@***.***>
Sent: Tuesday, September 20, 2022 11:53:51 AM
To: rajgoel/reveal.js-plugins ***@***.***>
Cc: Torsten Schenkel ***@***.***>; Comment ***@***.***>
Subject: Re: [rajgoel/reveal.js-plugins] Add ability to have notes in print-pdf (PR #142)
CAUTION: This message was sent from outside the University, purportedly from ***@***.*** .
Please check the sender is legitimate before responding. Please treat any links or attachments with care - do not follow or open them unless you are sure they are genuine.
If there is a quality indication about the worst case offset that can occur I'd be willing to inspect this in more detail.
—
Reply to this email directly, view it on GitHub<#142 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMOMX2FNN6TWTUMXAQO6H2LV7GJT7ANCNFSM5KASELWA>.
You are receiving this because you commented.Message ID: ***@***.***>
|
|
Interestingly, the offset is also there if replayed on the same screen where it was recorded. It seems that the json doesn't take the margin into account properly?
May need to open another issue on that.
…________________________________
From: Schenkel, Torsten ***@***.***>
Sent: Tuesday, September 20, 2022 12:12:13 PM
To: rajgoel/reveal.js-plugins ***@***.***>; rajgoel/reveal.js-plugins ***@***.***>
Cc: Torsten Schenkel ***@***.***>; Comment ***@***.***>
Subject: Re: [rajgoel/reveal.js-plugins] Add ability to have notes in print-pdf (PR #142)
I'm not sure what that offset would be in print, but I do find huge offsets between different screen sizes for the default margins and scaling factors.
I need to set margins to below 5% and Max scale to >5 to make the drawings match up between recording and replay.
So the offset issue is not necessarily related to the print output, but a deeper issue?
________________________________
From: Asvin Goel ***@***.***>
Sent: Tuesday, September 20, 2022 11:53:51 AM
To: rajgoel/reveal.js-plugins ***@***.***>
Cc: Torsten Schenkel ***@***.***>; Comment ***@***.***>
Subject: Re: [rajgoel/reveal.js-plugins] Add ability to have notes in print-pdf (PR #142)
CAUTION: This message was sent from outside the University, purportedly from ***@***.*** .
Please check the sender is legitimate before responding. Please treat any links or attachments with care - do not follow or open them unless you are sure they are genuine.
If there is a quality indication about the worst case offset that can occur I'd be willing to inspect this in more detail.
—
Reply to this email directly, view it on GitHub<#142 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMOMX2FNN6TWTUMXAQO6H2LV7GJT7ANCNFSM5KASELWA>.
You are receiving this because you commented.Message ID: ***@***.***>
|
|
The calculation of the correct coordinates is pretty tricky and so far I haven't found a clear solution to this. For live presentations and printouts of chalkboard drawings, this is not a big problem, but for printouts of notes this is a different story. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch as an overlay canvas to the generated PDF print version to
render the notes added to the slides. To keep the current default behavior,
this feature must be enabled by setting the new configuration option "printNotes"
to
true.Unfortunately the relative positioning between the drawings and the slide content
is not perfect since the rendering of the slide content slightly differs in the
pdf-print mode.
This patch addresses issue #97