Fix node v14 test in CI (#1311)

raineorshine · Jul 28, 2023 · 86ce798 · 86ce798
1 parent 19f10fe
commit 86ce798
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 28 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -42,8 +42,16 @@ jobs:
           node-version: ${{ matrix.node }}
           cache: npm
 
+      # node v14 cannot install from current package-lock.json, so use npm install instea of npm ci.
+      # Cannot read property 'chalk' of undefined
+      # Regression: e88617964a009dbb9f5e973f64ff76ad289df68c
+      - name: Install npm dependencies
+        run: npm i
+        if: 'matrix.node == 14'
+
       - name: Install npm dependencies
         run: npm ci
+        if: 'matrix.node != 14'
 
       - name: Build
         run: npm run build

diff --git a/.ncurc.js b/.ncurc.js
@@ -15,5 +15,7 @@ module.exports = {
     // Waiting for Prettier v3 support in @trivago/prettier-plugin-sort-imports
     // https://github.com/trivago/prettier-plugin-sort-imports/issues/240
     'prettier',
+    // Removed support for node v14 in v0.35.0
+    'makdownlint-cli',
   ],
 }
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -126,7 +126,7 @@
     "eslint-plugin-promise": "^6.1.1",
     "husky": "^8.0.3",
     "lockfile-lint": "^4.10.6",
-    "markdownlint-cli": "^0.35.0",
+    "markdownlint-cli": "0.34.0",
     "mocha": "^10.2.0",
     "npm-run-all": "^4.1.5",
     "prettier": "^2.8.8",