Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed Extended File Support for Flashcard Generator #98

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

youngsunlee07
Copy link

Implemented support for multiple file attachments in the Flashcard Generator as part of Epic 7.2. This update enhances the application's ability to handle various file types, improving flexibility and user experience. Requesting code review.

Copy link
Collaborator

@hash2004 hash2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome awesome work! Solve the minor issues and submit your PR with proper screenshots (according to the PR template) and tests. Rest looks clean!

Dockerfile Outdated
COPY ./app /code/app
COPY ./app /code/app

# .env 파일 복사
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary comments should be removed.

app/main.py Outdated
load_dotenv(find_dotenv())
load_dotenv(find_dotenv())

# 추가된 부분
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove unnecessary comments

requirements.txt Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include fastapi[standard]

@youngsunlee07
Copy link
Author

I have incorporated the feedback and pushed the changes. Please review the updated code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants