-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completed Extended File Support for Flashcard Generator #98
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome awesome work! Solve the minor issues and submit your PR with proper screenshots (according to the PR template) and tests. Rest looks clean!
Dockerfile
Outdated
COPY ./app /code/app | ||
COPY ./app /code/app | ||
|
||
# .env 파일 복사 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unnecessary comments should be removed.
app/main.py
Outdated
load_dotenv(find_dotenv()) | ||
load_dotenv(find_dotenv()) | ||
|
||
# 추가된 부분 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove unnecessary comments
requirements.txt
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include fastapi[standard]
I have incorporated the feedback and pushed the changes. Please review the updated code. |
Implemented support for multiple file attachments in the Flashcard Generator as part of Epic 7.2. This update enhances the application's ability to handle various file types, improving flexibility and user experience. Requesting code review.