Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [Internal RG] Unit page - manage tags xblocks #238

Draft
wants to merge 73 commits into
base: romaniuk/render-xblock-component
Choose a base branch
from

Conversation

GlugovGrGlib
Copy link

In this PR:

added the tag counter for each component on the Course Unit page;
added "Manage Tags" menu item with handler to open/close Tags menu;
reordered menu items due to this https://github.com/openedx/frontend-app-course-authoring/issues/966.

Developer notes

This PR is temporary built on openedx#964. So only last 5 commits starting from feat: [AXIMST-560] display tags count on each component are relevant to this feature.

Testing instructions

Run master devstack.
Start platform make dev.up.lms+cms+frontend-app-course-authoring and make checkout on this branch.
Enable the new Unit page by adding a waffle flag contentstore.new_studio_mfe.use_new_unit_page in the CMS admin panel.
Go to the Course Unit page from the Course Outline page.
Add a new xblock component.

@@ -40,6 +40,10 @@ const messages = defineMessages({
defaultMessage: 'Delete',
description: 'The xblock delete button text',
},
blockLabelButtonManageTags: {
id: 'course-authoring.course-unit.xblock.button.manageTags.label',
defaultMessage: 'Manage tags',
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khudym Add description

Copy link
Author

@GlugovGrGlib GlugovGrGlib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add descriptions to translation messages

const messages = defineMessages({
tooltipText: {
id: 'course-authoring.generic.tag-count.tooltip.text',
defaultMessage: 'Manage tags',
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add description

@GlugovGrGlib GlugovGrGlib changed the title feat: [FC-0044] Unit page - manage tags xblocks feat: [Internal RG] Unit page - manage tags xblocks Apr 30, 2024
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the romaniuk/render-xblock-component branch 2 times, most recently from 9fe40e0 to 20af604 Compare April 30, 2024 17:04
vladislavkeblysh and others added 3 commits April 30, 2024 18:38
Implement Textbooks page.

---------

Co-authored-by: Glib Glugovskiy <[email protected]>
* feat: More spacing between search bar and selectmenu
* feat: Autofocus search field when modal opens
* feat: Fix issues with scroll to search result
This includes the following:
  - The target search element is aligned to the top of the page when scrolling to it
  - Makes sure the section/subsection is expanded in order to scroll to result
* fix: Match focus border radius with button's
* fix: Only expand (sub)section with search result
Set arrow down for expanded section/subsection and right arrow for
collapsed items same as legacy
@khudym khudym force-pushed the hudym/Unit-page-manage-tags-xblocks branch from d2b35b5 to 929bd25 Compare May 3, 2024 14:05
ChrisChV and others added 2 commits May 3, 2024 20:04
Updates the code of Tag Drawer to send two messages to parent (if the drawer is a iframe) when the tags are updated:

- One message with updated content tags.
- One message with the content tags count.
@khudym khudym force-pushed the hudym/Unit-page-manage-tags-xblocks branch 2 times, most recently from d272df7 to 9f76ddc Compare May 3, 2024 20:34
ChrisChV and others added 17 commits May 6, 2024 14:46
* refactor: Further refinements to tag drawer
* Padding to top and left tagging drawer
* Changes in headings in the tagging drawer
…#988)

when we've expanded a taxonomy in read mode with no content tags added.
* feat: enable tagging/taxonomy feature by default

* test: improve coverage

* chore: fix lint issue
Sort blocktypes on hierarchy then alphabet.
* feat: [AXIMST-538] Add errors handling 4xx, 5xx

* fix: resolve discussions

* fix: second round of review discussions

refactor: fixing tests for Textbooks page

Co-authored-by: ruzniaievdm <[email protected]>
Adds the new "Other tags" Section to tags drawer that contains the taxonomies/tags that the user doesn't have permission to see/edit. It allow to delete those tags.
* fix: allow page grid to take plugin slot id instead

* chore: add config check

* chore: linting

* chore: variable more readable
* fix: hide release and due dates config in self paced courses

* feat: discussion enable setting for unit in outline

* refactor: message text

Co-authored-by: Kristin Aoki <[email protected]>

* fix: modal dialog overflow

---------

Co-authored-by: Kristin Aoki <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot and others added 26 commits June 24, 2024 09:02
…v2.4.0 (openedx#1118)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* feat: add upload progress modal

* fix: increase code coverage

* fix: fix code to be more readable

* fix: delete empty file
…v2.4.1 (openedx#1132)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* feat: add upload progress modal

* fix: increase code coverage

* fix: fix code to be more readable

* fix: delete empty file

* fix: failing test and lint

* fix: progress bar not updating

* feat: add missing abort controller on POST to edxVal
* chore: convert all 'search-modal' code to TypeScript

* fix: lint should check .ts[x] files too

* fix: remove unused dependency meilisearch-instantsearch
…x#1133)

* fix: update mapToStateProps to match changes in TinyMceWidget

* feat: bump frontend-lib-content-components
…v2.4.3 (openedx#1140)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
openedx#1121)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* fix(deps): update dependency @openedx/paragon to v22.6.1

* fix: lint errors from stricter types in new paragon version

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…v2.5.0 (openedx#1143)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…v2.5.1 (openedx#1153)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@khudym khudym force-pushed the hudym/Unit-page-manage-tags-xblocks branch 2 times, most recently from 13c467f to 92939bb Compare July 22, 2024 22:15
@khudym khudym force-pushed the hudym/Unit-page-manage-tags-xblocks branch from 92939bb to 2b2abf6 Compare July 22, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.