forked from openedx/edx-platform
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [AXIMST-26] API endpoint to return components in unit #2486
Closed
ruzniaievdm
wants to merge
5
commits into
ts-develop-old
from
ruzniaievdm/feat/vertical-container-api
Closed
feat: [AXIMST-26] API endpoint to return components in unit #2486
ruzniaievdm
wants to merge
5
commits into
ts-develop-old
from
ruzniaievdm/feat/vertical-container-api
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er-drf feat: [AXIMST-10] Refactor Unit page view as DRF
ruzniaievdm
force-pushed
the
ruzniaievdm/feat/vertical-container-api
branch
from
January 5, 2024 14:38
834ab65
to
11f5728
Compare
ruzniaievdm
force-pushed
the
ruzniaievdm/feat/vertical-container-api
branch
from
January 5, 2024 16:20
11f5728
to
9164b5a
Compare
monteri
reviewed
Jan 8, 2024
Comment on lines
+53
to
+61
def get_object(self, usage_key_string): | ||
""" | ||
Get an object by usage-id of the block | ||
""" | ||
try: | ||
usage_key = UsageKey.from_string(usage_key_string) | ||
except InvalidKeyError: | ||
raise Http404 # lint-amnesty, pylint: disable=raise-missing-from | ||
return usage_key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
def get_object(self, usage_key_string): | |
""" | |
Get an object by usage-id of the block | |
""" | |
try: | |
usage_key = UsageKey.from_string(usage_key_string) | |
except InvalidKeyError: | |
raise Http404 # lint-amnesty, pylint: disable=raise-missing-from | |
return usage_key | |
def get_object(self, usage_key_string): | |
""" | |
Get an object by usage-id of the block | |
""" | |
try: | |
usage_key = UsageKey.from_string(usage_key_string) | |
return usage_key | |
except InvalidKeyError as e: | |
logging.error(f"Invalid usage key: {usage_key_string}", exc_info=True) | |
raise Http404(f"Object not found for usage key: {usage_key_string}") from e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AXIMST-26