feat: [ACI-1031] Upgrade requirements and resolve conflicts #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove the dockerfile * remove the appropriate makefile targets * remove information about the unused testing docker from testing.rst FIXES: APER-3434
…edx#2472) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
removing the reliance on the visible_date attribute * re-factoring some tests, not just to make them work with the new code, but also because some of these tests were never ideal. They weren't all testing the right things, some of them never tested the code path that used certificate available date, and definitely a bunch have non-useful names and no comments. Several were testing impossible (or, definitionally broken) situations like program certificates with no corresponding course certificates. * added django stubs for type checking * added some type checking * modified a test not only to work with the new code but also to do a better job of validating what was looking for * added mypy * told coverage not to look for type checking conditionals * all tests now use certificate available date (which has another pending ticket to be removed as a toggle) * upgraded the Python version used to build the documentation because accessible-pygments requires a version greater than 3.8. * updating one more github CI python version
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ons (openedx#2515) * feat: making the django admin understand the signatory is not mandatory on coursecertificates Credentials IDA requires signatories on `ProgramCertificate` configurations. However, on `CourseCertificate` configurations, not all sites will care if a signatory is present. The certificates themselves don't render in the credentials IDA, and this is cloned data from the system of record. Although this has always been nullable in the ORM because of the way django handles nullability for `ManyToManyField`, the django admin enforces the presence of a signatory. This keeps the signatory required for `ProgramCertificate`, but makes it blankable for `CourseCertificate`. FIXES: APER-3494 Co-authored-by: Jason Wesson <[email protected]>
* chore: Upgrade Python requirements --------- Co-authored-by: Justin Hynes <[email protected]>
Co-authored-by: Andrii <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade requirements and resolve conflicts.
YouTrack
https://youtrack.raccoongang.com/issue/ACI-1031/Review-PRs-comments