-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(otel): add opentelemety utility functions #272
Draft
AndrewWinterman
wants to merge
8
commits into
rabbitmq:main
Choose a base branch
from
AndrewWinterman:feat/opentelemetry
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+455
−138
Commits on Jun 28, 2024
-
feat(otel): add opentelemety utility functions
This PR extracts opentelemetry utility functions from my private project and adds them to this project without calling them. It resolves rabbitmq#43 I'd like a broader discussion about whether these should be automatically called by the library where possible, or if they should simply be provided to clients to use if they so wish. I did my best to follow OpenTelemetry semantic conventions as described here https://opentelemetry.io/docs/specs/semconv/messaging/messaging-spans/, but they are at times ambiguous for rabbitmq-- e.g. is the destination for a message the Queue or the Consumer Tag the message was delivered to. Given the channel based approaches of this library, it is impossible for the library to know the full execution of a consumer. Unless autoack=false, we cannot actually know when to end the span associated with a delivery, so at least in the consumer case, it's probably best to allow the client to manage spans for themselves. We *can* manage spans on the producer side, and at the very least extract span identifiers to include on published headers automatically, and provide utilities for pulling them back out again. My intention with putting this PR up is to move the conversation forward. Because the PR *only* provides private methods (if I left members public please call them out), it can be safely merged while these questions are worked out.
Configuration menu - View commit details
-
Copy full SHA for d537aee - Browse repository at this point
Copy the full SHA d537aeeView commit details -
Configuration menu - View commit details
-
Copy full SHA for d292598 - Browse repository at this point
Copy the full SHA d292598View commit details
Commits on Jul 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 75a6aeb - Browse repository at this point
Copy the full SHA 75a6aebView commit details -
Merge branch 'feat/opentelemetry' of https://github.com/AndrewWinterm…
…an/amqp091-go into feat/opentelemetry
Configuration menu - View commit details
-
Copy full SHA for ccf814a - Browse repository at this point
Copy the full SHA ccf814aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 13a1894 - Browse repository at this point
Copy the full SHA 13a1894View commit details -
Configuration menu - View commit details
-
Copy full SHA for e0fa7c6 - Browse repository at this point
Copy the full SHA e0fa7c6View commit details -
Merge branch 'feat/opentelemetry' of https://github.com/AndrewWinterm…
…an/amqp091-go into feat/opentelemetry
Configuration menu - View commit details
-
Copy full SHA for 1aeb2d0 - Browse repository at this point
Copy the full SHA 1aeb2d0View commit details
Commits on Aug 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 47aa58b - Browse repository at this point
Copy the full SHA 47aa58bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.