skip cubble test; transform geometry array elements

closes loreabad6/vdc-space-time-feats#1
huizezhang-sherry/cubble#30

NEWS.md

@@ -1,5 +1,9 @@
 # version 0.6-6
 
+* skip `cubble` tests for cubble version 0.3.1; https://github.com/huizezhang-sherry/cubble/issues/30
+
+* `st_transform.stars` transforms geometries in array elements
+
 * `mutate.stars` (and others) handle attribute names with spaces in them; #689
 
 * `st_crop()` gains an argument `normalize`; when set to `TRUE` `st_normalize()` is called on the returned value; #685, #686

R/transform.R

@@ -67,11 +67,18 @@ transform_curvilinear = function(x, crs, ...) {
 #' plot(st_transform(st_as_sfc(x, as_points=FALSE), new), add = TRUE)
 #' @seealso \link{st_warp}
 #' @details For simple feature dimensions, \link[sf]{st_transform} is called, leading to lossless transformation. For gridded spatial data, a curvilinear grid with transformed grid cell (centers) is returned, which is also lossless. To convert this to a regular grid in the new \code{CRS}, use \link{st_warp} (which is in general lossy).
+#' 
+#' If array values contain geometries and an array as a whole is of class `sfc` and 
+#' has a non-missing CRS, array geometries are also transformed. 
 #' @export
 st_transform.stars =  function(x, crs, ...) {
 
 	stopifnot(!is.na(crs), !is.na(st_crs(x)))
 
+	for (i in seq_along(x)) {
+		if (inherits(x[[i]], "sfc") && !is.na(st_crs(x[[i]]))) # array cells are geometries
+			x[[i]] = structure(st_transform(x[[i]], crs), dim = dim(x[[i]]))
+	}
 	if (has_sfc(x)) {
 		if (!inherits(crs, "crs") && !inherits(crs, "stars"))
 			crs = st_crs(crs) # needed for GDAL's transform of features

tests/testthat/test-cubble.R

@@ -3,6 +3,7 @@ test_that("cubble", {
   skip_if_not_installed("dplyr")
   library(dplyr)
   library(cubble)
+  skip_if(packageVersion("cubble") == "0.3.1") # https://github.com/huizezhang-sherry/cubble/issues/30
   library(units)
   tm = set_units(1:6, "days since 1985-01-01")
   # l7 = st_as_stars(L7_ETMs) |> st_set_dimensions(3, values = Sys.time() + 1:6)