Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support error_arg for allow_rename = FALSE as well #359

Merged
merged 7 commits into from
Oct 25, 2024
Merged

Support error_arg for allow_rename = FALSE as well #359

merged 7 commits into from
Oct 25, 2024

Commits on Oct 23, 2024

  1. Add support for error_arg for allow_rename = FALSE

    @olivroy
    olivroy committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    0024e37 View commit details
    Browse the repository at this point in the history

  2. Update snapshots

    @olivroy
    olivroy committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    75cf6d5 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. merge

    @olivroy @lionel-
    olivroy authored and lionel- committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    d3ed1fd View commit details
    Browse the repository at this point in the history

  2. address comments move back error_arg down

    @olivroy @lionel-
    olivroy authored and lionel- committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    d61cd64 View commit details
    Browse the repository at this point in the history

  3. those are actually not used, removing

    @olivroy @lionel-
    olivroy authored and lionel- committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    a759189 View commit details
    Browse the repository at this point in the history

  4. avoid code duplicstion

    @olivroy @lionel-
    olivroy authored and lionel- committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    2db8846 View commit details
    Browse the repository at this point in the history

  5. Always pass a string to cli_abort()

    @lionel-
    lionel- committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    1f7dfa4 View commit details
    Browse the repository at this point in the history