Fix grammar in warning about bare predicates #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a predicate function is used in `select()` to select columns for which a function returns `TRUE`, a warning appears, saying: "Please use wrap predicates in `where()` instead.", which is grammatically incorrect. To correct the warning's grammar, this commit changes the warning to say: "Please use `where()` to wrap predicate functions instead."
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a predicate function is used in
select()to select columns for which a function returnsTRUE, a warning appears, saying: "Please use wrap predicates inwhere()instead.", which is grammatically incorrect.To correct the warning's grammar, this commit changes the warning to say: "Please use
where()to wrap predicate functions instead."