Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test math rendering in examples #2751

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Test math rendering in examples #2751

merged 1 commit into from
Nov 29, 2024

Conversation

jayhesselberth
Copy link
Collaborator

Part of #2704

@jayhesselberth
Copy link
Collaborator Author

@hadley are you ok with setting math-rendering: mathjax in the pkgdown site so that this renders correctly? Otherwise will need to figure out why the default mathml doesn't work.

@jayhesselberth jayhesselberth requested a review from hadley August 8, 2024 12:39
Copy link

github-actions bot commented Aug 8, 2024

@jayhesselberth
Copy link
Collaborator Author

@hadley just pinging this, ok to merge? We'll need an test of math rendering in the examples to address #2704 and related issues with math rendering.

@jayhesselberth jayhesselberth merged commit 6e1613c into main Nov 29, 2024
17 checks passed
@jayhesselberth jayhesselberth deleted the issue-2704 branch November 29, 2024 14:01
@jayhesselberth
Copy link
Collaborator Author

I merged this as we're going to need a test of math rendering in the examples. No clear yet why mathml doesn't work in this case.

@bastistician
Copy link
Contributor

@jayhesselberth (Just checked the status of the math bug and found this.) Why "in examples"? AFAICS, this test is not about \examples but about general Rd math, i.e., how a \[d]eqn gets rendered in /reference/.
Thanks for working on this!

@jayhesselberth
Copy link
Collaborator Author

jayhesselberth commented Dec 8, 2024

We didn't have a test in Rd examples, only in a vignette.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants