-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure SWA Staging Site(s) #334
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-mushroom-0564bdf0f-334.eastus2.5.azurestaticapps.net |
zleyyij
approved these changes
Aug 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really fucking cool, good shit
sealsrock12
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new GHA that will build "master" and up to 3? PRs against master into Azure SWA's and serve them at https://staging.rtech.support/ + 3 other random domains, which are a bit harder to find but are in the GHA output.
Implementation of this requires an edit to
Gemfile
which provides a version of Ruby to use. I am declaringruby '>=3.0'
because this is required bynokogiri
This could break people on MacOS which ships with 2.6.7, you need to use this fix on MacOS because the latest version of Ruby logger is also broken.
You may need to
bundle update
as well if you can start the serve command but it errors out after trying to start up.