Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4 and added new timer layout #14

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

gun4qmm7h
Copy link
Contributor

@gun4qmm7h gun4qmm7h commented Nov 12, 2021

Added vibrator feedback to Alarm Toggle, Alarm Day Toggle | Stopwatch start/stop, Stopwatch restart/share/lap.

Change layout for timer

Change layout for setting

Added #4

Note* Check code. As I said I'm very new so double check the code

Jawad added 16 commits November 10, 2021 10:46
Added vibration feedback to alarm Toggle and date Toggle.
Change timer layout a bit.
Change setting layout a bit.(power botton still in working progress)
Added vibration feedback to alarm Toggle and date Toggle.
Change timer layout a bit.
Change setting layout a bit.(power botton still in working progress)
Added vibration feedback to alarm Toggle and date Toggle.
Change timer layout a bit.
Change setting layout a bit.(power botton still in working progress)
Added vibration feedback to alarm Toggle and date Toggle.
Change timer layout a bit.
Change setting layout a bit.(power botton still in working progress)
Added vibration feedback to alarm Toggle and date Toggle.
Change timer layout a bit.
Change setting layout a bit.(power botton still in working progress)
# Conflicts:
#	app/src/main/res/layout/timer_setup_digits.xml
Added vibration feedback to alarm Toggle and date Toggle.
Change timer layout a bit.
Change setting layout a bit.(power botton still in working progress)
added power button to dismiss / snooze / do nothing
added vibration feedback to alarm toggle, selection alarm day, start/stop stopwatch, stopwatch lap/reset/share.
# Conflicts:
#	app/src/main/java/com/chen/deskclock/settings/SettingsActivity.java
#	app/src/main/res/layout/timer_setup_digits.xml
#	app/src/main/res/values/strings.xml
# Conflicts:
#	.idea/misc.xml
#	app/src/main/java/com/chen/deskclock/alarms/AlarmActivity.java
#	app/src/main/java/com/chen/deskclock/stopwatch/StopwatchFragment.java
#	app/src/main/res/layout/timer_setup_digits.xml
#	app/src/main/res/layout/timer_setup_time.xml
# Conflicts:
#	.idea/modules.xml
#	app/src/main/java/com/chen/deskclock/settings/SettingsActivity.java
#	app/src/main/java/com/chen/deskclock/timer/TimerSetupView.java
#	app/src/main/res/layout/timer_setup_digits.xml
@qw123wh
Copy link
Owner

qw123wh commented Nov 13, 2021

I can't compile the application, android studio gives me some errors. Can you generate an apk? If you can send it to me.

@qw123wh
Copy link
Owner

qw123wh commented Nov 13, 2021

If I delete these lines



it makes me compile an apk without problems, but when you open the app and click settings the app crashes

@qw123wh
Copy link
Owner

qw123wh commented Nov 13, 2021

@gun4qmm7h Thanks thank you so much for your help.

I solved it works, soon I will publish another more updated and modern clock project, it is ready I need some time to test and publish it, stop working on this project, wait until I publish the other one and then we will work on that

@gun4qmm7h
Copy link
Contributor Author

@qw123wh could you tell me what the problem was and how you fix it? I would love to learn from my mistakes.

@qw123wh
Copy link
Owner

qw123wh commented Nov 14, 2021

@gun4qmm7h actually I did not understand the error from what it was caused, maybe it was the application source code that had some problem, I don't think there are errors in your commits. Anyway take a look at this new version
https://github.com/qw123wh/new-clock
I added the changed the timer look and fixed # 4 thanks to your commits, I added swipe to delete alarm, then i changed the app name. I released a debug app try it and let me know if you like it

@gun4qmm7h
Copy link
Contributor Author

I love the new look and feel of it. I notice the vibration feedback is missing when clicking on things (I don't really care to much about it, just wondering why it's gone). Also are we moving to the new-clock project or is that just the early release version and it will be updated here later?

@qw123wh
Copy link
Owner

qw123wh commented Nov 15, 2021

We will switch to the new-clock version of the clock, this current version will be abandoned. The vibration feedback I have not added (for me the vibration to the touch has never worked), however if you want you can fork the new app and add this function, but if you are interested as a function, however, also add an option in the settings for be able to activate / deactivate the vibration feedback at the user's choice.

@gun4qmm7h
Copy link
Contributor Author

gun4qmm7h commented Nov 15, 2021

@qw123wh if it's ok with you, can you add me on discord so we can work on this new clock project together? I feeling like using discord would be easier then using GitHub.

@qw123wh
Copy link
Owner

qw123wh commented Nov 16, 2021

I have no discord, if you want the email to contact me is [email protected], write me there then I'll give you my telegram usurname

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants