Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(popup): userscript detail view #447

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Conversation

ACTCD
Copy link
Collaborator

@ACTCD ACTCD commented Mar 13, 2023

resolve #280

@ACTCD ACTCD marked this pull request as draft March 13, 2023 23:46
@quoid quoid marked this pull request as ready for review March 14, 2023 02:22
@quoid quoid marked this pull request as draft March 14, 2023 02:23
Comment on lines 72 to 71
padding: .5rem 1rem;
padding: .5rem;
Copy link
Collaborator Author

@ACTCD ACTCD Mar 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a scroll bar occlusion problem here. The scroll bar has two widths in different situations. When it becomes wider, it is not easy to click the button. Maybe we should customize the scrollbar.
图片

Comment on lines 53 to 58
@media (hover: none) {
.item .more {
border-left: .1rem solid rgb(255 255 255 / 0.075);
}
}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have an alternate design, or really don't need this? border-left was added to indicate the clickable area on devices without hover.

src/popup/Components/PopupItem.svelte Show resolved Hide resolved
@MpcOS77

This comment was marked as off-topic.

MpcOS77

This comment was marked as off-topic.

Repository owner deleted a comment from MpcOS77 Jun 1, 2024
Repository owner deleted a comment from MpcOS77 Jun 1, 2024
Repository owner deleted a comment from MpcOS77 Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't easily check script version in iOS version
3 participants