Spec: Remove "todo" from Assertion event data #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This is redundant with the information available in in the TestEnd event data. * We don't know of any testing frameworks that support flipping the "todo" status on a per-assertion basis, nor does that seem likely in the future as "Todo test" is defined as a test with one or more expected failures. * Presence of this in the spec was a barrier to entry as it means common assertion exception objects would require being cloned, mutated, or otherwise mapped to set accordingly. Fixes #105.
Krinkle
force-pushed
the
spec-rm-assert-todo
branch
from
852206f to
f547d28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is redundant with the information already available in
in the TestEnd event data.
We don't know of any testing frameworks that support flipping
the "todo" status on a per-assertion basis, nor does that
seem likely in the future as "Todo test" is defined as a test
with one or more expected failures.
Presence of this in the spec was a barrier to entry as it means
common assertion exception objects would require being cloned,
mutated, or otherwise mapped to set accordingly.
Fixes #105.