fix: remove unused dependency tracing-attributes #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
Jun 20, 2024
|
Very cool to see that quinn-udp is being considered for use in Firefox! |
Various `quinn*` crates depend on `tracing`. `tracing` in its default feature set includes `tracing-attributes` in order to expose `#[instrument]` procedural macro in `tracing::instrument`. None of `quinn*` make use of the `#[instrument]` macro. Thus the `tracing-attributes` dependency is unused. To remove the dependency from the tree, this commit restricts `tracing`'s `features` to `std`, effectively removing the `attributes` feature.
mxinden
force-pushed
the
rmv-tracing-attributes
branch
from
74bb27f
to
9ee56d8
Compare
Ralith
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various
quinn*crates depend ontracing.tracingin its default feature set includestracing-attributesin order to expose#[instrument]procedural macro intracing::instrument.None of
quinn*make use of the#[instrument]macro. Thus thetracing-attributesdependency is unused.To remove the dependency from the tree, this commit:
tracing'sfeaturestostd, effectively removing theattributesfeature.tracing*imports acrossquinn*crates into workspace dependencies.Let me know if you don't want to use workspace dependencies?
Context:
quinn-udp, see Suggestions for quinn-udp #1749.tracing-attributes) the better.As always, thank you for this project!