WIP Feat/cleanup #1
Conversation
|
Ok, quick question before I do anything else. Are you ok with me moving the code into a subfolder ( and, are you ok with me splitting up If so, I'll create 1 or 2 PR just for these changes. And only after I'll try to actually improve the code. |
Yes.
If the split is good, sure. |
| (:bind | ||
| ;; emacs is being weird about the indentation here, something specific about :bind | ||
| `((,(cadr binding-car) . ,actual-car))))) | ||
| (car-match-multiple (binding-car actual-car) |
There was a problem hiding this comment.
the "label" car-match-multiple was removed because it was not used (and sbcl was complaining)
|
🐖 |
src/checks.lisp
Outdated
| (let ((dirty-enodes-count | ||
| (hash-table-count (e-graph-dirty-e-nodes e-graph)))) | ||
| (unless (zerop dirty-enodes-count) | ||
| (warn "The e-graph is dirty! It has ~d dirty nodes." |
| (when (and (symbolp tree) | ||
| (string= "_" tree)) | ||
| (warn "Tried to compile a pattern involving a symbol named \"_\" in a package other than CLUCK. This will not be treated as a wildcard!")) | ||
| (and (symbolp tree) |
There was a problem hiding this comment.
keep this a when since warn is effectively side effectful
There was a problem hiding this comment.
The warn is now inside the and, the code works the same
Unless you're giving me a style warning 😉
There was a problem hiding this comment.
yes it's a style warning. AND is for computing values, not having a shortcut for WHEN :)
There was a problem hiding this comment.
AND is for computing values, not having a shortcut for WHEN
cries in sh
There was a problem hiding this comment.
crosses pointer fingers perpendicularly such that they lie in a plane whose normal is directed toward sh
| nil | ||
| 'no-match)) | ||
| (unless (eql a b) | ||
| 'no-match)) |
There was a problem hiding this comment.
don't remove NIL if the value is meaningful. in this case it is since a boolean is being returned.
use WHEN / UNLESS for side effects only
|
|
||
| (defun default-merge-car-bound-values-fn (a b id) | ||
| (declare (ignore id)) | ||
| (if (eql a b) |
| @@ -9,9 +9,8 @@ | |||
| (defun hash-table-peek (ht) | |||
| (with-hash-table-iterator (next ht) | |||
| (multiple-value-bind (has-value-p k) (next) | |||
| (if has-value-p | |||
| (if (eql (cadr binding-car) actual-car) | ||
| nil | ||
| 'no-match)) | ||
| (unless (eql (second binding-car) actual-car) |
apart from the obvious move into src/ and split, I removed the function "prin1-e-node-to-string" and I might have broken something doing that. I didn't test yet.
I also extracted a function
warn-if-dirty