Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metastore_uri deduced from old variables example #93

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add metastore_uri deduced from old variables example #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ database: metastore
username: quickwit
assword: ""
```
Configure `QW_METASTORE_URI` in `extraEnvFrom` instead (see
You can use `config.metastore_uri` or `QW_METASTORE_URI` in `extraEnvFrom` instead (see
[documentation](https://quickwit.io/docs/configuration/metastore-config) for
more details).
more details). `metastore_uri` can be built with the old variables like this: `postgres://$(POSTGRES_USERNAME):$(POSTGRES_PASSWORD)@$(POSTGRES_HOST):$(POSTGRES_PORT)/$(POSTGRES_DATABASE)`.
Copy link
Collaborator

@idrissneumann idrissneumann Jul 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why refer to this as "old variables" ? Because they seems aren't mentioned somewhere anymore.

I'd replace "old" with "already defined environment variables on the pod" which can take other names btw, for example: postgres://$(PG_USER):$(PG_PASSWORD)@$(PG_HOST):$(PG_PORT)/$(PG_DATABASE).

It'll work regardless of the name if those environment variables are defined on the pod with extraEnv.


- the seed configuration has moved from `config` to a dedicated attribute. The
changes are:
Expand Down
Loading