Refactoring Kubernetes recommanded labels #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas Lamirault <[email protected]>
nlamirault
changed the title
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
5 tasks
rdettai
reviewed
May 6, 2024
| @@ -4,7 +4,8 @@ kind: ServiceAccount | |||
| metadata: | |||
| name: {{ include "quickwit.serviceAccountName" . }} | |||
| labels: | |||
| {{- include "quickwit.labels" . | nindent 4 }} | |||
| {{- include "quickwit.labels" . | nindent 4 -}} | |||
There was a problem hiding this comment.
- argument of nindent can be left out to be consistent with the rest of the include statements
| {{- include "quickwit.control_plane.selectorLabels" . | nindent 8 }} | ||
| {{- include "quickwit.additionalLabels" . | nindent 8 }} |
There was a problem hiding this comment.
quickwit.additionalLabels is already part of quickwit.labels
| @@ -64,39 +65,34 @@ app.kubernetes.io/instance: {{ .Release.Name }} | |||
| Searcher Selector labels | |||
| */}} | |||
| {{- define "quickwit.searcher.selectorLabels" -}} | |||
| {{ include "quickwit.selectorLabels" . }} | |||
There was a problem hiding this comment.
why not include common selector labels anymore?
There was a problem hiding this comment.
in metadata we have:
labels:
{{- include "quickwit.labels" . | nindent 4 }}
{{- include "quickwit.control_plane.selectorLabels" . | nindent 4 }}So in we don't remove common selector labels from control_plane.selectorLabels, the common selector labels will be added twice (one by quickwit.labels and one by control_plane.selectorLabels)
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
* main: (42 commits) Bump appVersion to 0.8.2 Feat issue quickwit-oss#98: merging jobs and bootstrap section Fix metastore volume indentation Bump to v0.6.4 Fix helm chart comments Reduce indentation by 2 Bump version to 0.6.2 Introduce component specific initContainers, volumes and volumeMounts Use nodeSelector, affinity, tolerations from bootstrap config values. This ensures pods generated from k8s Job have these settings propagated. Allow command and args to be overridden via values files. This helps in providing custom config files generated from templates as necessary Add possibility to specify services type per service fix: readme missing newlines fix: readme suggested changes fix: add back indexer & search settings example fix: readme depreciation notice chore: document the breaking change and change the versioning accordingly fix: add QW_METASTORE_URI doc chore: add configMapRef example in values.yaml fix: add suggested change Add artifacthub metadata file feat: add requested changes fix: quickwit secret leak in configmap ... Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All resources have Kubernetes recommended labels