Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: runtimeClassName annotation support so we can support gVisor (GKE Sandbox) #100

Merged
merged 2 commits into from
Oct 15, 2024
Merged

feat: runtimeClassName annotation support so we can support gVisor (GKE Sandbox) #100

merged 2 commits into from
Oct 15, 2024

Conversation

isaachall
Copy link
Contributor

@isaachall isaachall commented Sep 7, 2024 •
edited
Loading

This adds the runtimeClassName annotation to Deployments, Jobs, and StatefulSets so the containers can run within GKE Sandbox (gVisor). This helps with PCI compliance.

values.yaml:

searcher:
  runtimeClassName: gvisor

indexer:
  runtimeClassName: gvisor

metastore:
  runtimeClassName: gvisor

control_plane:
  runtimeClassName: gvisor

janitor:
  runtimeClassName: gvisor

bootstrap:
  runtimeClassName: gvisor

@guilload
Copy link
Member

@isaachall, do you mind resolving the conflict and bumping the chart's version to 0.7.3 so we can merge this PR?

@isaachall
Copy link
Contributor Author

@guilload Conflict resolved & version bumped. I just finished testing the update on my cluster. Thanks!

@guilload guilload merged commit 24ad2b8 into quickwit-oss:main Oct 15, 2024
1 check passed
@isaachall isaachall deleted the runtimeClassName branch October 15, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guilload guilload guilload approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isaachall @guilload