Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deploy command script #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: deploy command script #14

wants to merge 1 commit into from

Conversation

raae
Copy link
Member

@raae raae commented Feb 5, 2023

  • move deployment script back as standalone, but call it as a part for the start script

davidwessman
davidwessman approved these changes Feb 5, 2023
View reviewed changes
package.json
@@ -7,8 +7,8 @@
"type": "module",
"scripts": {
"dev": "node --watch .",
"start": "node .",
"deploy": "node src/deploy-commands"
"start": "node src/deploy-commands & node .",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want it to run after the deploy?

Suggested change
"start": "node src/deploy-commands & node .",
"start": "node src/deploy-commands && node .",

or after

Suggested change
"start": "node src/deploy-commands & node .",
"start": "node src/deploy-commands; node .",

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we use "&" its parallel...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwessman davidwessman davidwessman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raae @davidwessman