Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vex: fetcher add changes before archived data #1389

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

crozzy
Copy link
Contributor

@crozzy crozzy commented Aug 22, 2024

By switching how the VEX data is appended to the output spool we allow the parser to ignore duplicates rather than have to process things twice. This helps in situations where RH prodsec update a large number of files and haven't updated the archive data.

@crozzy crozzy requested a review from a team as a code owner August 22, 2024 17:20
@crozzy crozzy requested review from hdonnay and removed request for a team August 22, 2024 17:20
@crozzy crozzy force-pushed the reverse-vex-fetching branch from 4d83092 to 959fe9d Compare August 22, 2024 17:20
@crozzy
Copy link
Contributor Author

crozzy commented Aug 22, 2024

I went through the zip (and tar) rabbitholes and still ended up here.

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 24 lines in your changes missing coverage. Please review.

Project coverage is 55.41%. Comparing base (66c3c9b) to head (7088f7b).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
rhel/vex/fetcher.go 63.63% 14 Missing and 10 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1389      +/-   ##
==========================================
+ Coverage   55.32%   55.41%   +0.09%     
==========================================
  Files         282      282              
  Lines       17861    17890      +29     
==========================================
+ Hits         9881     9914      +33     
+ Misses       6939     6934       -5     
- Partials     1041     1042       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crozzy crozzy force-pushed the reverse-vex-fetching branch 2 times, most recently from a61d1dc to 7c2f7fa Compare September 13, 2024 22:48
@crozzy crozzy force-pushed the reverse-vex-fetching branch 3 times, most recently from 02b5747 to eb98fcf Compare September 23, 2024 16:29
But switching how the VEX data is appended to the output spool we allow
the fetcher to ignore the files in the archive that have been changed.

Signed-off-by: crozzy <[email protected]>
@crozzy crozzy force-pushed the reverse-vex-fetching branch from eb98fcf to 7088f7b Compare September 23, 2024 19:04
@crozzy
Copy link
Contributor Author

crozzy commented Sep 23, 2024

/fast-forward

@github-actions github-actions bot merged commit 7088f7b into quay:main Sep 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants