Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent @typescript-eslint/unbound-method error on newer utilities types #17251

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

maiolica
Copy link
Contributor

@maiolica maiolica commented Jun 4, 2024

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:
The types change has been made to prevent the @typescript-eslint/unbound-method error on the new utility types (see https://stackoverflow.com/a/62864909).

Copy link

github-actions bot commented Jun 4, 2024

Build Results

JSON API

📜 No changes detected.

Types

📜 Changes detected:

diff --git a/./current-build/types/composables.d.ts b/./pr-build/types/composables.d.ts
index 1266dba..b9e7486 100644
--- a/./current-build/types/composables.d.ts
+++ b/./pr-build/types/composables.d.ts
@@ -32,8 +32,8 @@ export function useHydration(): {
 };
 
 export function useInterval(): {
-  registerInterval(fn: () => void, interval: string | number): void;
-  removeInterval(): void;
+  registerInterval: (fn: () => void, interval: string | number) => void;
+  removeInterval: () => void;
 };
 
 export function useId(opts?: {
@@ -60,11 +60,11 @@ export function useSplitAttrs(): {
 };
 
 export function useTick(): {
-  registerTick(fn: () => void): void;
-  removeTick(): void;
+  registerTick: (fn: () => void) => void;
+  removeTick: () => void;
 };
 
 export function useTimeout(): {
-  registerTimeout(fn: () => void, delay?: string | number): void;
-  removeTimeout(): void;
+  registerTimeout: (fn: () => void, delay?: string | number) => void;
+  removeTimeout: () => void;
 };

@maiolica maiolica changed the title fix: prevent @typescript-eslint/unbound method error on newer utilities types fix: prevent @typescript-eslint/unbound-method error on newer utilities types Jun 4, 2024
@rstoenescu rstoenescu merged commit a45122e into quasarframework:dev Jun 5, 2024
1 check passed
@rstoenescu
Copy link
Member

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants