Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local test run resilience fix & refactors. #1243

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

local test run resilience fix & refactors. #1243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 32 additions & 42 deletions ...rt/aggregator/src/test/java/org/acme/kafka/streams/aggregator/streams/AggregatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,40 +1,32 @@
package org.acme.kafka.streams.aggregator.streams;

import static org.acme.kafka.streams.aggregator.streams.TopologyProducer.TEMPERATURES_AGGREGATED_TOPIC;
import static org.acme.kafka.streams.aggregator.streams.TopologyProducer.TEMPERATURE_VALUES_TOPIC;
import static org.acme.kafka.streams.aggregator.streams.TopologyProducer.WEATHER_STATIONS_TOPIC;

import java.time.Duration;
import java.time.Instant;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
import java.util.Properties;
import java.util.concurrent.TimeUnit;

import io.quarkus.kafka.client.serialization.ObjectMapperDeserializer;
import io.quarkus.kafka.client.serialization.ObjectMapperSerializer;
import io.quarkus.test.common.QuarkusTestResource;
import io.quarkus.test.junit.QuarkusTest;
import org.acme.kafka.streams.aggregator.model.Aggregation;
import org.acme.kafka.streams.aggregator.model.WeatherStation;
import org.apache.kafka.clients.consumer.Consumer;
import org.apache.kafka.clients.consumer.ConsumerConfig;
import org.apache.kafka.clients.consumer.ConsumerRecord;
import org.apache.kafka.clients.consumer.ConsumerRecords;
import org.apache.kafka.clients.consumer.KafkaConsumer;
import org.apache.kafka.clients.CommonClientConfigs;
import org.apache.kafka.clients.consumer.*;
import org.apache.kafka.clients.producer.KafkaProducer;
import org.apache.kafka.clients.producer.ProducerConfig;
import org.apache.kafka.clients.producer.ProducerRecord;
import org.apache.kafka.common.serialization.IntegerDeserializer;
import org.apache.kafka.common.serialization.IntegerSerializer;
import org.apache.kafka.common.serialization.StringSerializer;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.Timeout;

import io.quarkus.kafka.client.serialization.ObjectMapperDeserializer;
import io.quarkus.kafka.client.serialization.ObjectMapperSerializer;
import io.quarkus.test.common.QuarkusTestResource;
import io.quarkus.test.junit.QuarkusTest;
import java.time.Duration;
import java.time.Instant;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
import java.util.Properties;

import static org.acme.kafka.streams.aggregator.streams.TopologyProducer.*;
import static org.junit.jupiter.api.Assertions.assertEquals;

/**
* Integration testing of the application with an embedded broker.
Expand All @@ -44,20 +36,18 @@
public class AggregatorTest {

KafkaProducer<Integer, String> temperatureProducer;

KafkaProducer<Integer, WeatherStation> weatherStationsProducer;

KafkaConsumer<Integer, Aggregation> weatherStationsConsumer;

@BeforeEach
public void setUp(){
temperatureProducer = new KafkaProducer(producerProps(), new IntegerSerializer(), new StringSerializer());
weatherStationsProducer = new KafkaProducer(producerProps(), new IntegerSerializer(), new ObjectMapperSerializer());
weatherStationsConsumer = new KafkaConsumer(consumerProps(), new IntegerDeserializer(), new ObjectMapperDeserializer<>(Aggregation.class));
public void setUp() {
temperatureProducer = new KafkaProducer<>(properties(), new IntegerSerializer(), new StringSerializer());
weatherStationsProducer = new KafkaProducer<>(properties(), new IntegerSerializer(), new ObjectMapperSerializer<>());
weatherStationsConsumer = new KafkaConsumer<>(consumerProps(), new IntegerDeserializer(), new ObjectMapperDeserializer<>(Aggregation.class));
}

@AfterEach
public void tearDown(){
public void tearDown() {
temperatureProducer.close();
weatherStationsProducer.close();
weatherStationsConsumer.close();
Expand All @@ -68,29 +58,29 @@ public void tearDown(){
public void test() {
weatherStationsConsumer.subscribe(Collections.singletonList(TEMPERATURES_AGGREGATED_TOPIC));
weatherStationsProducer.send(new ProducerRecord<>(WEATHER_STATIONS_TOPIC, 1, new WeatherStation(1, "Station 1")));
temperatureProducer.send(new ProducerRecord<>(TEMPERATURE_VALUES_TOPIC, 1,Instant.now() + ";" + "15" ));
temperatureProducer.send(new ProducerRecord<>(TEMPERATURE_VALUES_TOPIC, 1,Instant.now() + ";" + "25" ));
List<ConsumerRecord<Integer, Aggregation>> results = poll(weatherStationsConsumer,1);
temperatureProducer.send(new ProducerRecord<>(TEMPERATURE_VALUES_TOPIC, 1, Instant.now() + ";" + "15"));
temperatureProducer.send(new ProducerRecord<>(TEMPERATURE_VALUES_TOPIC, 1, Instant.now() + ";" + "25"));
Aggregation result = poll(weatherStationsConsumer, 1).get(0).value();

// Assumes the state store was initially empty
Assertions.assertEquals(2, results.get(0).value().count);
Assertions.assertEquals(1, results.get(0).value().stationId);
Assertions.assertEquals("Station 1", results.get(0).value().stationName);
Assertions.assertEquals(20, results.get(0).value().avg);
//should be: result.count == 2, but repeated local test run (without maven clean) accumulates +2
//because kafka persistence is located on target/data
assertEquals(0, result.count % 2);
assertEquals(1, result.stationId);
assertEquals("Station 1", result.stationName);
assertEquals(20, result.avg);
}

private Properties consumerProps() {
Properties props = new Properties();
props.put(ProducerConfig.BOOTSTRAP_SERVERS_CONFIG, KafkaResource.getBootstrapServers());
Properties props = properties();
props.put(ConsumerConfig.GROUP_ID_CONFIG, "test-group-id");
props.put(ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG, "true");
props.put(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG, "earliest");
return props;
}

private Properties producerProps() {
private Properties properties() {
Properties props = new Properties();
props.put(ProducerConfig.BOOTSTRAP_SERVERS_CONFIG, KafkaResource.getBootstrapServers());
props.put(CommonClientConfigs.BOOTSTRAP_SERVERS_CONFIG, KafkaResource.getBootstrapServers());
return props;
}

Expand Down