Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket implement getSession() #167

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

melloware
Copy link
Contributor

This comment has been minimized.

@melloware
Copy link
Contributor Author

@cescoffier can you run again the build please?

@melloware melloware force-pushed the patch-1 branch 3 times, most recently from 75441b8 to a58e224 Compare October 16, 2024 15:16
@gastaldi
Copy link
Contributor

Any chance to add a test too?

@melloware
Copy link
Contributor Author

Shit this is not an HTTP Request its Vertx httpRequest it has no session?

This comment has been minimized.

@gastaldi
Copy link
Contributor

LOL, love how you created a PR using the GitHub UI and let the CI handle the compilation details 🤣

@melloware
Copy link
Contributor Author

I thought it was gonna be easy! VertX is a foreign place to me. OK I think I grabbed the only place a session could possible come from the exchange

@gastaldi
Copy link
Contributor

That's why a test would be nice to have ;)

This comment has been minimized.

Copy link

quarkus-bot bot commented Oct 16, 2024

Status for workflow Build

This is the status report for running Build on commit 43302d2.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@melloware
Copy link
Contributor Author

cc @stuartwdouglas @gsmet

@melloware
Copy link
Contributor Author

I would love the get this fix in 3.16.0 so I can verify MyFaces websockets are working any chance of this?

@gastaldi gastaldi merged commit 3ab7d0a into quarkusio:main Oct 22, 2024
3 checks passed
@melloware melloware deleted the patch-1 branch October 22, 2024 14:38
@gastaldi
Copy link
Contributor

@melloware try building locally and setting the dependency version explicitly in your project. Let us know how it goes

@melloware
Copy link
Contributor Author

@gastaldi cna you give me some guidance how can I use Quarkus 3.15.1 and override just this 1 dependency? I was a little confused on how to just override Quarkus HTTP?

@gastaldi
Copy link
Contributor

gastaldi commented Oct 22, 2024

Sure, just declare the modules produced here again as dependencies in your pom.xml, Maven should use it instead

@melloware
Copy link
Contributor Author

OK this helped I posted on Zulip. I now see what the problem is...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants