-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebSocket implement getSession() #167
Conversation
This comment has been minimized.
This comment has been minimized.
@cescoffier can you run again the build please? |
75441b8
to
a58e224
Compare
Any chance to add a test too? |
Shit this is not an HTTP Request its Vertx httpRequest it has no session? |
This comment has been minimized.
This comment has been minimized.
LOL, love how you created a PR using the GitHub UI and let the CI handle the compilation details 🤣 |
I thought it was gonna be easy! VertX is a foreign place to me. OK I think I grabbed the only place a session could possible come from the |
That's why a test would be nice to have ;) |
This comment has been minimized.
This comment has been minimized.
Status for workflow
|
I would love the get this fix in 3.16.0 so I can verify MyFaces websockets are working any chance of this? |
@melloware try building locally and setting the dependency version explicitly in your project. Let us know how it goes |
@gastaldi cna you give me some guidance how can I use Quarkus 3.15.1 and override just this 1 dependency? I was a little confused on how to just override Quarkus HTTP? |
Sure, just declare the modules produced here again as dependencies in your pom.xml, Maven should use it instead |
OK this helped I posted on Zulip. I now see what the problem is... |
Original bug report on MyFaces: https://issues.apache.org/jira/projects/MYFACES/issues/MYFACES-4684