Fix Websocket ping after close. Fix Websocket unhandled exception. #100
+28
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for quarkusio#99 where a Websocket ping was responded after session was marked closed and other messages were dropped. Fix for unhandled exceptions in Websocket channel pipeline. FrameHandler catches them and passes to onError instead of ignoring and running in default logger / stack trace printing by DefaultChannelPipeline.TailContext.
|
Let me know were you put tests, if you like unit or integration tests. I didn't find any suitable place. |
stuartwdouglas
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #99 where a Websocket ping was responded after session was marked closed and other messages were dropped.
Fix for unhandled exceptions in Websocket channel pipeline. FrameHandler catches them
and passes to onError instead of ignoring and running in default logger / stack trace printing by DefaultChannelPipeline.TailContext.