Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check n - 1 version if a guides link does not exist #223

Merged

Conversation

holly-cummins
Copy link
Collaborator

We are seeing failures because kogito is not in the 3.0 platform, so short-form guides links do not work. Longer term, we want something like quarkusio/registry.quarkus.io#188, but in the tactical short term, we can extend the existing url mapping to handle this case. Unlike for the camel guide links, we need to hardcode what version to guess.

Array [
    +   "https://quarkus.io/guides/kogito => 404 (Not Found) on http://localhost:9000/org.kie.kogito/kogito-addons-quarkus-jobs-service-embedded",
    +   "https://quarkus.io/guides/kogito-dmn => 404 (Not Found) on http://localhost:9000/org.kie.kogito/kogito-addons-quarkus-events-decisions",
    +   "https://quarkus.io/guides/kogito-pmml => 404 (Not Found) on http://localhost:9000/org.kie.kogito/kogito-addons-quarkus-events-predictions",
    +   "https://quarkus.io/guides/kogito-drl => 404 (Not Found) on http://localhost:9000/org.kie.kogito/kogito-addons-quarkus-events-rules",
    + ]

…s caused by kogito not yet being in 3.0 platform)
@github-actions
Copy link

github-actions bot commented May 3, 2023

🙈 The PR is closed and the preview is expired.

@holly-cummins holly-cummins merged commit 2f9bfa4 into quarkusio:main May 3, 2023
@holly-cummins holly-cummins deleted the more-guide-url-remapping branch May 3, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant