Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor bookmark manager #79

Merged
merged 35 commits into from
Mar 10, 2024
Merged

Refactor bookmark manager #79

merged 35 commits into from
Mar 10, 2024

Conversation

quambene
Copy link
Owner

@quambene quambene commented Mar 10, 2024

  • Select sources for bogrep configure if no sources are configured
  • Fix removing ignored urls

Copy link

codecov bot commented Mar 10, 2024

Codecov Report

Attention: Patch coverage is 90.22416% with 157 lines in your changes are missing coverage. Please review.

Project coverage is 90.33%. Comparing base (ddc1e00) to head (a5dc2c7).

Files Patch % Lines
src/bookmarks/bookmark_service.rs 87.40% 65 Missing ⚠️
src/bookmarks/bookmark_manager.rs 95.78% 21 Missing ⚠️
src/cmd/configure.rs 86.36% 18 Missing ⚠️
src/bookmarks/target_bookmarks.rs 91.82% 13 Missing ⚠️
src/bookmark_reader/source_reader.rs 0.00% 6 Missing ⚠️
src/bookmarks/mod.rs 64.70% 6 Missing ⚠️
src/client.rs 80.00% 6 Missing ⚠️
src/cmd/fetch.rs 85.71% 4 Missing ⚠️
src/bookmarks/source_bookmarks.rs 66.66% 3 Missing ⚠️
src/cmd/import.rs 90.00% 3 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
- Coverage   91.27%   90.33%   -0.94%     
==========================================
  Files          36       36              
  Lines        6327     5641     -686     
==========================================
- Hits         5775     5096     -679     
+ Misses        552      545       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quambene quambene merged commit f436d49 into main Mar 10, 2024
12 of 13 checks passed
@quambene quambene deleted the refactor-bookmark-manager branch March 10, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant