Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch underlyings #70

Merged
merged 28 commits into from
Jan 22, 2024
Merged

Fetch underlyings #70

merged 28 commits into from
Jan 22, 2024

Conversation

quambene
Copy link
Owner

Fetch underlyings

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 93 lines in your changes are missing coverage. Please review.

Comparison is base (2a2104b) 90.53% compared to head (c1d3d4f) 90.73%.

Files Patch % Lines
src/bookmarks/bookmark_processor.rs 62.68% 50 Missing ⚠️
src/cmd/fetch.rs 86.86% 13 Missing ⚠️
src/bookmarks/target_bookmarks.rs 92.10% 9 Missing ⚠️
src/bookmark_reader/target_reader.rs 92.95% 5 Missing ⚠️
src/client.rs 87.09% 4 Missing ⚠️
src/cmd/add.rs 95.29% 4 Missing ⚠️
src/args.rs 0.00% 2 Missing ⚠️
src/settings.rs 97.33% 2 Missing ⚠️
src/bookmarks/mod.rs 87.50% 1 Missing ⚠️
src/cache.rs 97.77% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
+ Coverage   90.53%   90.73%   +0.20%     
==========================================
  Files          31       32       +1     
  Lines        4513     4978     +465     
==========================================
+ Hits         4086     4517     +431     
- Misses        427      461      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quambene quambene merged commit aa0b9bb into main Jan 22, 2024
12 of 13 checks passed
@quambene quambene deleted the fetch-underlyings branch January 22, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant