Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fixes and improvements #69

Merged
merged 7 commits into from
Jan 14, 2024
Merged

Conversation

quambene
Copy link
Owner

@quambene quambene commented Jan 14, 2024

  • Fix duplicate cache files for bogrep fetch --urls
  • Fix report of processed bookmarks
  • Take ignored urls into account in bogrep import
  • Remove integration-test feature

Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (0a9db70) 90.20% compared to head (68880d8) 90.51%.

Files Patch % Lines
src/cmd/fetch.rs 64.00% 18 Missing ⚠️
src/bookmarks/target_bookmarks.rs 87.83% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   90.20%   90.51%   +0.30%     
==========================================
  Files          31       31              
  Lines        4432     4513      +81     
==========================================
+ Hits         3998     4085      +87     
+ Misses        434      428       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quambene quambene changed the title Fix duplicate cache files, take ingored urls into account, and remove integration-test feature Implement fixes and improvements Jan 14, 2024
@quambene quambene merged commit 2a2104b into main Jan 14, 2024
12 of 13 checks passed
@quambene quambene deleted the overwrite-existing-bookmark-cache branch January 14, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant