Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable markdown mode #48

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Enable markdown mode #48

wants to merge 4 commits into from

Conversation

quambene
Copy link
Owner

@quambene quambene commented Nov 16, 2023

To enable markdown mode again, the following needs to be fixed:

  1. panics for bogrep <pattern> --mode markdown (cf. thread 'main' panicked #30) ✔️
  2. conversion from HTML to markdown is leading to >1 GB markdown files for a few urls (while plaintext files are still a few kilobytes)

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (0c9cd10) 91.59% compared to head (5611298) 91.34%.

Files Patch % Lines
src/cache.rs 0.00% 7 Missing ⚠️
src/cmd/search.rs 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
- Coverage   91.59%   91.34%   -0.25%     
==========================================
  Files          26       26              
  Lines        3401     3410       +9     
==========================================
  Hits         3115     3115              
- Misses        286      295       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quambene quambene mentioned this pull request Nov 17, 2023
@mattmartini
Copy link

I just tried markdown mode and it still hangs after downloading some content.

@quambene
Copy link
Owner Author

quambene commented Nov 17, 2023

that's the second part (see description above) which is not fixed yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants