#issue 235 ->Add Chinese translation #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating help related to the nick and kick commands. Signed-off-by: Skydrgon <[email protected]>
Arkaeriit
reviewed
Aug 19, 2024
Arkaeriit
reviewed
Aug 19, 2024
README.md
Outdated
| @@ -128,7 +134,7 @@ The rest | |||
| pwd Show your current room | |||
| shrug ¯\_(ツ)_/¯ | |||
| ``` | |||
|
|
|||
| tips: `kick` can help kick out your previous id if the nickname is taken due to network delays. | |||
There was a problem hiding this comment.
Great idea to mention that. Maybe adding an example in a code block could be useful.
There was a problem hiding this comment.
yeah good to include but imo a code block is not needed
quackduck
reviewed
Aug 19, 2024
Signed-off-by: WhiteFlames <[email protected]>
Skydrgon
commented
Aug 29, 2024
README-CN.md
Outdated
| 在聊天室中: | ||
| OLDnick> nick NEWnick | ||
| NEWnick: | ||
| ``` |
There was a problem hiding this comment.
Took both of your comments and updated them.
Removed code block about nick.
quackduck
reviewed
Aug 29, 2024
|
Looks good, thank you so much @Skydrgon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#235
Add Chinese translation for README.md, the file is README-CN.md.
Updating help related to the nick and kick commands.
Not sure how to include a link to README-CN.md in README.md, do I need to commit this branch first and then reference it via markdown later?